yoast/yoastcs

PHP_CodeSniffer rules for Yoast projects

Tuesday, July 31, 2018
by omarreiss
Repository
16 Watchers
12 Stars
24,460 Installations

PHP
12 Dependents
0 Suggesters
4 Forks
9 Open issues
33 Versions
10 % Grown

The README.md

Yoast Coding Standards

, _(*1)

Yoast Coding Standards (YoastCS) is a project with rulesets for code style and quality tools to be used in Yoast projects., _(*2)

Installation

Standalone

Standards are provided as a Composer package and can be installed with:, _(*3)

composer global config allow-plugins.dealerdirect/phpcodesniffer-composer-installer true
composer global require --dev yoast/yoastcs:"^3.0"

As dependency

To include standards as part of a project require them as development dependencies:, _(*4)

composer config allow-plugins.dealerdirect/phpcodesniffer-composer-installer true
composer require --dev yoast/yoastcs:"^3.0"

Composer will automatically install dependencies and register YoastCS and other external standards with PHP_CodeSniffer., _(*5)

Tools provided via YoastCS

PHP Parallel Lint
PHP_CodeSniffer and select standards for PHP_CodeSniffer, including a number of Yoast native sniffs.

PHP Parallel Lint

PHP Parallel Lint is a tool to lint PHP files against parse errors., _(*6)

PHP Parallel Lint does not use a configuration file, so command-line options need to be passed to configure what files to scan., _(*7)

It is best practice within the Yoast projects, to add a script to the composer.json file which encapsules the command with the appropriate command-line options to ensure that running the tool will yield the same results each time., _(*8)

Typically, (a variation on) the following snippet would be added to the composer.json file for a project:, _(*9)

    "scripts" : {
        "lint": [
            "@php ./vendor/php-parallel-lint/php-parallel-lint/parallel-lint . -e php --show-deprecated --exclude vendor --exclude .git"
        ]
    }

PHP Code Sniffer

Set of PHP_CodeSniffer rules., _(*10)

Severity levels:, _(*11)

error level issues are considered mandatory to fix in Yoast projects and enforced in continuous integration
warning level issues are considered recommended to fix

The YoastCS Standard

The Yoast standard for PHP_CodeSniffer is comprised of the following: * The WordPress ruleset from the WordPress Coding Standards implementing the official WordPress PHP Coding Standards, with some select exclusions. * The PHPCompatibilityWP ruleset which checks code for PHP cross-version compatibility while preventing false positives for functionality polyfilled within WordPress. * The VariableAnalysis ruleset. * Select additional sniffs taken from PHP_CodeSniffer. * Select additional sniffs taken from PHPCSExtra. * Select additional sniffs taken from SlevomatCodingStandard. * Select additional sniffs taken from WordPress VIP Coding Standards. * A number of custom Yoast specific sniffs., _(*12)

Files within version management and dependency related directories, such as the Composer vendor directory, are excluded from the scans by default., _(*13)

Sniffs

To obtain a list of all sniffs used within YoastCS:, _(*14)

"vendor/bin/phpcs" -e --standard=Yoast

Sniff Documentation

Not all sniffs have documentation available about what they sniff for, but for those which do, this documentation can be viewed from the command-line:, _(*15)

"vendor/bin/phpcs" --standard=Yoast --generator=Text

Running the sniffs

Command line

"vendor/bin/phpcs" --extensions=php /path/to/folder/

For more command-line options, please have a read through the PHP_CodeSniffer documentation., _(*16)

Yoast plugin repositories

All Yoast plugin repositories contain a [.]phpcs.xml.dist file which contains the repository specific configuration., _(*17)

From the root of these repositories, you can run PHPCS by using:, _(*18)

composer check-cs-warnings

PhpStorm

Refer to Using PHP Code Sniffer Tool in the PhpStorm documentation., _(*19)

After installation, the Yoast standard will be available as a choice in PHP Code Sniffer Validation inspection., _(*20)

The YoastCS "Threshold" report

The YoastCS package includes a custom YoastCS\Yoast\Reports\Threshold report for PHP_CodeSniffer to compare the current PHPCS run results with predefined "threshold" settings., _(*21)

The report will look in the runtime environment for the following two environment variables and will take the values of those as the thresholds to compare the PHPCS run results against: * YOASTCS_THRESHOLD_ERRORS * YOASTCS_THRESHOLD_WARNINGS, _(*22)

If the environment variables are not set, they will default to 0 for both, i.e. no errors or warnings allowed., _(*23)

The report will not print any details about the issues found, it just shows a summary based on the thresholds:, _(*24)

PHP CODE SNIFFER THRESHOLD COMPARISON
------------------------------------------------------------------------------------------------------------------------
Coding standards ERRORS: 148/130.
Coding standards WARNINGS: 539/539.

Please fix any errors introduced in your code and run PHPCS again to verify.
Please fix any warnings introduced in your code and run PHPCS again to verify.

After the report has run, a global YOASTCS_ABOVE_THRESHOLD constant (boolean) will be available which can be used in calling scripts., _(*25)

To use this report, run PHPCS with the following command-line argument: --report=YoastCS\Yoast\Reports\Threshold. Note: depending on the OS the command is run on, the backslashes in the report name may need to be escaped (doubled)., _(*26)

For those Yoast plugin repositories which use thresholds, the status can be checked locally by running:, _(*27)

composer check-cs-thresholds

Changelog

The changelog for this package can be found in the CHANGELOG.md file., _(*28)

The Versions

31/07 2018

dev-JRF/WIP/sniff-check-placement-testdoubles

PHP_CodeSniffer rules for Yoast projects

phpcodesniffer-standard yoastcs

PHP_CodeSniffer rules for Yoast projects

yoast/yoastcs

The README.md

Yoast Coding Standards

Installation

Standalone

As dependency

Tools provided via YoastCS

PHP Parallel Lint

PHP Code Sniffer

The YoastCS Standard

Sniffs

Sniff Documentation

Running the sniffs

Command line

Yoast plugin repositories

PhpStorm

The YoastCS "Threshold" report

Changelog

The Versions

dev-JRF/WIP/sniff-check-placement-testdoubles

The Requires

The Development Requires

by Team Yoast

dev-develop

The Requires

The Development Requires

by Team Yoast

dev-JRF/add-function-close-sniff

The Requires

The Development Requires

by Team Yoast

dev-74-introduce-required-parameters-sniff

The Requires

The Development Requires

by Team Yoast

dev-JRF/dont-allow-warnings

The Requires

The Development Requires

by Team Yoast

dev-JRF/add-functionspacing-sniff

The Requires

The Development Requires

by Team Yoast

dev-JRF/update-for-new-releases-phpcompatibility-wpcs

The Requires

The Development Requires

by Team Yoast

dev-JRF/yoastcs-native-ruleset-phpcs-3.3.0-adjustment

The Requires

The Development Requires

by Team Yoast

dev-JRF/remove-end-comments

The Requires

The Development Requires

by Team Yoast

dev-JRF/composer-add-explanation-to-suggest

The Requires

The Development Requires

by Team Yoast

dev-74-introduce-optional-parameters-sniff

The Requires

The Development Requires

by Team Yoast

dev-master

The Requires

The Development Requires

by Team Yoast

0.5

The Requires

by Team Yoast

dev-JRF/improve-ifelse-sniff

The Requires

by Team Yoast

dev-JRF/update-to-wpcs-0.14.0

The Requires

by Team Yoast

dev-JRF/phpcompatibility-allow-for-wp-backfills

The Requires